api3dao / airnode

Airnode monorepo
https://docs.api3.org/
MIT License
165 stars 72 forks source link

Airnode PRs are failing on the E2E test step #1551

Closed aTeoke closed 1 year ago

aTeoke commented 1 year ago

A number of airnode PRs are failing on the E2E test step with the same error: Unable to find value at path: 'market_data.current_price.usd'.

related discussion: https://api3workspace.slack.com/archives/C02AYRX8D89/p1669272881427619

dcroote commented 1 year ago

Debugging (in-progress)

Siegrift commented 1 year ago

The reason is https://github.com/axios/axios/issues/5298 the response in the Airnode when run from a docker container looks like this:

image

Unfortunately, I had to add a log to print out the request response (we don't log this because there can be sensitive information). Not sure if we should not revisit this decision, because the logs are not helpful.

I see there is already a fix PR created so we can upgrade axios after that point... https://github.com/axios/axios/pull/5306 not sure how this passed through CI though.

martinkolenic commented 1 year ago

Hi @Siegrift , I assume this will be tested at the first completed PR, correct? Don't think we can test this from the user's perspective. I'll move this to Done if you give me an A-OK.

Siegrift commented 1 year ago

I assume this will be tested at the first completed PR, correct?

Since https://github.com/api3dao/airnode/pull/1553 passed the tests we can consider this tested. Feel free to move to DONE.