api3dao / airnode

Airnode monorepo
https://docs.api3.org/
MIT License
160 stars 66 forks source link

Some config.json files are invalid #1993

Closed dcroote closed 1 month ago

dcroote commented 2 months ago

There are numerous flavors of config.json within the repo:

❯ find packages/ -type f -name "*config*.json" ! -name "tsconfig.json"
packages/airnode-node/test/fixtures/config/config.valid.json
packages/airnode-node/config/config.example.json
packages/airnode-examples/integrations/coingecko-post-processing/config.example.json
packages/airnode-examples/integrations/coingecko-http-gateways/config.json
packages/airnode-examples/integrations/coingecko-http-gateways/config.example.json
packages/airnode-examples/integrations/authenticated-coinmarketcap/config.example.json
packages/airnode-examples/integrations/relay-security-schemes/config.example.json
packages/airnode-examples/integrations/coingecko-template/config.example.json
packages/airnode-examples/integrations/coingecko-cross-chain-authorizer/config.example.json
packages/airnode-examples/integrations/coingecko/config.example.json
packages/airnode-examples/integrations/failing-example/config.example.json
packages/airnode-examples/integrations/weather-multi-value/config.example.json
packages/airnode-examples/integrations/coingecko-pre-processing/config.example.json
packages/airnode-validator/test/fixtures/invalid-secret-name/config.json
packages/airnode-validator/test/fixtures/interpolated-config.valid.json
packages/airnode-validator/test/fixtures/config.valid.json
packages/airnode-deployer/test/fixtures/config.aws.valid.json
packages/airnode-deployer/test/fixtures/config.gcp.valid.json
packages/airnode-deployer/config/config.example.json
packages/airnode-operation/src/config/evm-dev-config.json

Some of which are invalid per airnode-validator (I quickly tested using an approach similar to this comment).

These should be fixed, and going forward, perhaps tested in a more automated fashion to prevent becoming outdated again.