search

api3dao / airseeker

A service powering the dAPIs
MIT License
2 stars 5 forks source link

Use node@20 in the Docker image #340

Closed Siegrift closed 1 month ago

Siegrift commented 2 months ago

Currently, we use v18, which will be EoL soon.

Siegrift commented 2 months ago

Security patches end in 10months https://endoflife.date/nodejs.

As a note, this is trivial to implement, but it needs to be tested for potential breakages.

dcroote commented 1 month ago

I can take this one, but would need some guidance on a suitable testing strategy.

BTT21000 commented 1 month ago

Deployments to be done on testnets

dcroote commented 1 month ago

Wouldn't it also make sense to fully commit to node v20 if we're updating it in the Dockerfile? It would necessitate changes in in the Actions workflow and package.json:

https://github.com/api3dao/airseeker/blob/79d02d1d1a4ad5776844d04f6a31e963c0f49114/package.json#L7

@bdrhn9 ?

bdrhn9 commented 1 month ago

Wouldn't it also make sense to fully commit to node v20 if we're updating it in the Dockerfile? It would necessitate changes in in the Actions workflow and package.json:

Yes it would be 👍🏼