api3dao / api3-dao-dashboard

API3 DAO dashboard
api3.eth/
14 stars 10 forks source link

Fix Dockerization issues #328

Closed Siegrift closed 2 years ago

Siegrift commented 2 years ago

Fixes https://linear.app/api3-dao/issue/DAO-205/verify-dao-dashboard-in-docker-works-on-all-platforms

Description

Initially it was reported that the dockerized version is not working on Windows, but I realized it doesn't work also on the new m1 macOS (due to a different issue).

I've also changed the instructions in the README to clone the repo using HTTPS instead of SSH since the SSH requires more setup and is not really needed.

Code changes

Tested

I followed the README steps with one change. Instead of running:

git clone --depth=1 --branch production https://github.com/api3dao/api3-dao-dashboard.git

I run

git clone --depth=1 --branch dao-205 https://github.com/api3dao/api3-dao-dashboard.git

Tested on:

linear[bot] commented 2 years ago
DAO-205 Verify DAO dashboard in docker works on all platforms

Based of [https://api3workspace.slack.com/archives/C02ALA11APM/p1662495175336859](https://api3workspace.slack.com/archives/C02ALA11APM/p1662495175336859)