search

api3dao / api3-dao-dashboard

API3 DAO dashboard
api3.eth/
14 stars 14 forks source link

Unpin @percy/cli from v1.18.0 #436

Open mcoetzee opened 8 months ago

mcoetzee commented 8 months ago

Taking snapshots with Percy fails in our Cypress tests from v1.19 (which is why it was pinned to v1.18.0)

TypeError: Cannot read properties of null (reading 'sheet')
      at styleSheetFromNode (http://localhost:3000/__cypress/tests?p=cypress/support/e2e.ts)
      at serializeCSSOM (http://localhost:3000/__cypress/tests?p=cypress/support/e2e.ts)
      at serializeElements (http://localhost:3000/__cypress/tests?p=cypress/support/e2e.ts)
      at Object.serializeDOM (http://localhost:3000/__cypress/tests?p=cypress/support/e2e.ts)
      at Context.eval (webpack://api3-dao-dashboard/./node_modules/@percy/cypress/index.js:59:0)

Shadow DOM serialisation seems to be the main thing introduced with v1.19 https://github.com/percy/cli/releases/tag/v1.19.2

It might be related to the web3modal because it uses shadow DOM.