search

api3dao / api3-dao-dashboard

API3 DAO dashboard
api3.eth/
14 stars 10 forks source link

Bump versions of Actions steps in order to add provenance #441

Closed dcroote closed 7 months ago

dcroote commented 7 months ago

"Attestations are supported with version 4 and later of the docker/build-push-action" (source) - this PR updates from v3 to v5, and updates other steps as well.

EDIT: The production branch is the only one from which images get pushed because of this bool:

https://github.com/api3dao/api3-dao-dashboard/blob/b8befd30d13bf352c12b2bfd4e0a0b239352c5de/.github/workflows/build-docker.yml#L37

so I originally opened the PR against production, but realized that didn't make sense since commits are merged from main to production. In rebasing, I did notice GitHub is having some trouble reconciling main and production: see this compare. I'm guessing, based on the co-authored commits on production that a "rebase and merge" was used in #432 instead of using a merge commit.

dcroote commented 7 months ago

I agree it's disappointing GitHub doesn't allow for this, but at least the merge strategy, as the lesser of several evils, avoids the branches appearing to diverge.