dcroote
commented
1 month ago Ugh. I regret adding the Shopify no-ancestor-directory-import rule. It appears there isn't a way to satisfy the rule (i.e. "without relying on an index file") given that in some directories the index.ts file contains the exported code and it's tested in index.test.ts by importing like the following:
https://github.com/api3dao/commons/blob/77a02932bb7b19b7232bd0756c158ec3397daf9d/src/config-hash/index.test.ts#L5
I propose removing the rule and release v2.0.1. WDYT @Siegrift ?
Siegrift
This PR contains the following updates:
^1.0.1->^2.0.0Release Notes
api3dao/eslint-plugin-commons (@api3/eslint-plugin-commons)
### [`v2.0.0`](https://togithub.com/api3dao/eslint-plugin-commons/releases/tag/v2.0.0) [Compare Source](https://togithub.com/api3dao/eslint-plugin-commons/compare/v1.0.1...v2.0.0) #### BREAKING CHANGES Add 3 rules from Shopify by [@dcroote](https://togithub.com/dcroote) in [https://github.com/api3dao/eslint-plugin-commons/pull/19](https://togithub.com/api3dao/eslint-plugin-commons/pull/19) - [@shopify/prefer-early-return](https://togithub.com/Shopify/web-configs/blob/main/packages/eslint-plugin/docs/rules/prefer-early-return.md) - [@shopify/prefer-module-scope-constants](https://togithub.com/Shopify/web-configs/blob/main/packages/eslint-plugin/docs/rules/prefer-module-scope-constants.md) - [@shopify/no-ancestor-directory-import](https://togithub.com/Shopify/web-configs/blob/main/packages/eslint-plugin/docs/rules/no-ancestor-directory-import.md) #### Other changes - Add common exclusions by [@dcroote](https://togithub.com/dcroote) in [https://github.com/api3dao/eslint-plugin-commons/pull/20](https://togithub.com/api3dao/eslint-plugin-commons/pull/20) - this should help avoid having to add similar exclusions across many repos - Update pnpm to v9 by [@dcroote](https://togithub.com/dcroote) in [https://github.com/api3dao/eslint-plugin-commons/pull/16](https://togithub.com/api3dao/eslint-plugin-commons/pull/16) - ci: ignore node in renovate by [@dcroote](https://togithub.com/dcroote) in [https://github.com/api3dao/eslint-plugin-commons/pull/23](https://togithub.com/api3dao/eslint-plugin-commons/pull/23) **Full Changelog**: https://github.com/api3dao/eslint-plugin-commons/compare/v1.0.1...v2.0.0Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.