search

api3dao / commons

Common utilities, modules and configurations used in API3 projects
MIT License
0 stars 2 forks source link

Enable Node.js 20 and test in CI #40

Closed dcroote closed 10 months ago

dcroote commented 10 months ago

Closes #38

dcroote commented 10 months ago

The Build, lint and test matrix strategy works as both Node 18 and 20 jobs pass, but the "Required" test is hanging.

I don't have admin access to the repo, but I would strongly guess that this is because there is a branch protection rule for main that requires the Build, lint and test CI step to pass. The reason for it hanging now is I've renamed "Build, lint and test" to include the Node version.

See here for how to edit

Siegrift commented 10 months ago

We should have the All required checks set in GH settings.

image

This way we don't need to remember to update the GH settings after a new Node version is added/removed.