api3dao / eslint-plugin-commons

The standard ESLint rule set for API3 projects
0 stars 0 forks source link

Make less strict ESLint config for testing files #14

Open Siegrift opened 10 months ago

Siegrift commented 10 months ago

Testing requires creating mocks and using fixtures and sometimes uglier mutable code. This is fine (and sometimes preferred) for tests, but with our strict production ESLint configuration we need to use multiple eslint disable comments which is ugly.

We could turn off the problematic rules in the test config (only applied for tests files based on filename pattern).

dcroote commented 3 months ago

Close now that the eslint plugin has moved?

Siegrift commented 3 months ago

I'd transfer instead. That said, this is not necessarily the priority.