api3dao / eslint-plugin-commons

The standard ESLint rule set for API3 projects
0 stars 0 forks source link

Final updates before release #7

Closed dcroote closed 2 weeks ago

dcroote commented 2 weeks ago

For the first commit, lodash 8.0.0 has eslint@>=9.0.0 as a peer dependency so I downgraded (lodash v8 also seems to haven be taken over by an individual from the previous maintainer(s); I didn't look further into it)

I tested this in 2 repos:

  1. ois - where there are a lot of lints, but most are decent and/or can be fixed with --fix
  2. A private OEV repo that currently uses commons/eslint functionality (universal and jest) - I replaced the local import with this plugin and no new errors were raised besides 3 new Unused eslint-disable directive that result from a @typescript-eslint package version bump between this repo and eslint within commons.

which means after this is merged, I think we're ready for release and use.