api3dao / old-api3-docs

Documentation for the API3 Project
https://docs.api3.org/
MIT License
56 stars 29 forks source link

Remove --detach from airnode-client commands #1214

Closed dcroote closed 1 year ago

dcroote commented 1 year ago

Closes #1213. The docker run arguments -it aren't needed in this case and arent' used in airnode-examples:

https://github.com/api3dao/airnode/blob/08a2985a4cde546283956457c9a87f1237d7e380/packages/airnode-examples/src/scripts/run-airnode-locally.ts#L25-L39

github-actions[bot] commented 1 year ago

Visit the preview URL for this PR (updated for commit 10f5e98):

https://api3-docs--pr1214-dcroote-issue1213-iw62vbcg.web.app

(expires Sun, 12 Mar 2023 21:32:07 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d319eb7cbe610768342d5dc1b5cd1f3aed912886

wkande commented 1 year ago

@dcroote did you remove the use of --detach to illustrate the use of logs in the guide for the container? Making it easier to access the logs I guess.

dcroote commented 1 year ago

By removing --detach, logs are now output to the console, which is more befitting of a user tutorial.