tokers commented 3 years ago

This PR implements the etcd v3 watch request. Only watching for apisix/routes and apisix/upstreams (as prefix) are effective, watching other keys won't give any responses.

codecov[bot] commented 3 years ago

Codecov Report

Merging #23 (b5238fd) into main (60694c5) will decrease coverage by 0.48%. The diff coverage is 74.62%.

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   76.81%   76.32%   -0.49%     
==========================================
  Files          22       23       +1     
  Lines        1117     1449     +332     
==========================================
+ Hits          858     1106     +248     
- Misses        205      270      +65     
- Partials       54       73      +19

Impacted Files	Coverage Δ
pkg/etcdv3/kv.go	`67.56% <0.00%> (-0.93%)`	:arrow_down:
pkg/etcdv3/watch.go	`63.86% <63.86%> (ø)`
pkg/etcdv3/etcd.go	`87.61% <87.95%> (+0.94%)`	:arrow_up:
pkg/etcdv3/conformance.go	`100.00% <100.00%> (ø)`
pkg/sidecar/types.go	`67.27% <100.00%> (+4.52%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 60694c5...0237bad. Read the comment docs.

tokers commented 3 years ago

@membphis @starsz @gxthrj Please take a look when you have time.

api7 / apisix-mesh-agent

feat: etcdv3 watch request #23

Codecov Report