Closed tokers closed 3 years ago
Merging #39 (7a46495) into main (cf4788b) will decrease coverage by
0.77%
. The diff coverage is54.28%
.
@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 74.31% 73.53% -0.78%
==========================================
Files 28 29 +1
Lines 1962 2048 +86
==========================================
+ Hits 1458 1506 +48
- Misses 391 418 +27
- Partials 113 124 +11
Impacted Files | Coverage Δ | |
---|---|---|
pkg/etcdv3/etcd.go | 71.11% <25.00%> (-2.04%) |
:arrow_down: |
pkg/sidecar/types.go | 54.54% <28.57%> (-9.64%) |
:arrow_down: |
pkg/sidecar/apisix.go | 57.69% <57.69%> (ø) |
|
cmd/iptables/clenaup-iptables.go | 47.36% <100.00%> (ø) |
|
cmd/iptables/iptables.go | 91.04% <100.00%> (+0.72%) |
:arrow_up: |
pkg/config/types.go | 96.00% <100.00%> (+0.54%) |
:arrow_up: |
pkg/provisioner/xds/v3/grpc/types.go | 76.96% <0.00%> (+2.61%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 03bfb46...5a49005. Read the comment docs.
Should we temporarily disable ciLint Checkers
?
@spacewander I will do some research on it. If the golangci-lint cannot run for go/1.16, I will disable it temporarily.
@tokers We can merge this PR first if you have done. We can do this later https://github.com/api7/apisix-mesh-agent/pull/39#issuecomment-799385708
OK.
@membphis Please take a look when you have time.