api7 / apisix-mesh-agent

Apache License 2.0
78 stars 10 forks source link

test: add istio charts #42

Closed tokers closed 3 years ago

tokers commented 3 years ago

Now Istio can be deployed in e2e cases. Most of files under e2e/charts are copied from Istio repository. Only a few files should be concerned.

codecov[bot] commented 3 years ago

Codecov Report

Merging #42 (cb209b7) into main (93f7cc8) will decrease coverage by 2.00%. The diff coverage is 44.68%.

:exclamation: Current head cb209b7 differs from pull request most recent head fdb252b. Consider uploading reports for the commit fdb252b to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
- Coverage   73.05%   71.05%   -2.01%     
==========================================
  Files          31       34       +3     
  Lines        2223     2318      +95     
==========================================
+ Hits         1624     1647      +23     
- Misses        465      530      +65     
- Partials      134      141       +7     
Impacted Files Coverage Δ
pkg/apisix/base.pb.validate.go 0.00% <0.00%> (ø)
pkg/set/string.go 36.36% <36.36%> (ø)
pkg/apisix/base.pb.go 36.53% <36.53%> (ø)
pkg/adaptor/xds/v3/cluster.go 67.44% <40.00%> (-0.03%) :arrow_down:
pkg/adaptor/xds/v3/route.go 76.15% <50.00%> (-1.33%) :arrow_down:
pkg/provisioner/xds/v3/grpc/types.go 71.10% <69.23%> (-1.38%) :arrow_down:
pkg/adaptor/xds/v3/listener.go 72.72% <100.00%> (ø)
pkg/cache/upstream.go 100.00% <100.00%> (ø)
pkg/etcdv3/etcd.go 71.11% <100.00%> (ø)
pkg/etcdv3/kv.go 71.87% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93f7cc8...fdb252b. Read the comment docs.

membphis commented 3 years ago

this pr is big and complex(for me), need @gxthrj 's help

gxthrj commented 3 years ago

Why not introduce istio charts as a dependency ?

tokers commented 3 years ago

Why not introduce istio charts as a dependency ?

We need to change it.