search

api7 / apisix-mesh-agent

Apache License 2.0
78 stars 10 forks source link

fix: send EDS request only if clusters changed #44

Closed tokers closed 3 years ago

tokers commented 3 years ago

We should send an EDS request when number of eds-required clusters (The cluster load assignment depends on another EDS config source) changed.

codecov[bot] commented 3 years ago

Codecov Report

Merging #44 (ad0f84a) into main (b20db82) will increase coverage by 0.16%. The diff coverage is 100.00%.

:exclamation: Current head ad0f84a differs from pull request most recent head 13debf2. Consider uploading reports for the commit 13debf2 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   73.23%   73.40%   +0.16%     
==========================================
  Files          30       30              
  Lines        2100     2113      +13     
==========================================
+ Hits         1538     1551      +13     
  Misses        433      433              
  Partials      129      129
Impacted Files Coverage Δ
pkg/provisioner/xds/v3/grpc/delivery.go 54.92% <100.00%> (+0.64%) :arrow_up:
pkg/provisioner/xds/v3/grpc/types.go 72.22% <100.00%> (+1.63%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b20db82...13debf2. Read the comment docs.

tokers commented 3 years ago

@membphis Please help me to review this PR when you have time, thanks!