search

api7 / apisix-mesh-agent

Apache License 2.0
78 stars 10 forks source link

feat: remove domain suffix from generated name #71

Closed lingsamuel closed 3 years ago

lingsamuel commented 3 years ago

APISIX has a limit of 100 characters. Remove the suffix to avoid easily encountering this limit.

tokers commented 3 years ago

Conflicts should be resolved firstly @lingsamuel .

codecov[bot] commented 3 years ago

Codecov Report

Merging #71 (3ed4cfd) into main (4b9c2bb) will increase coverage by 0.32%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   72.29%   72.61%   +0.32%     
==========================================
  Files          32       32              
  Lines        2256     2257       +1     
==========================================
+ Hits         1631     1639       +8     
+ Misses        483      477       -6     
+ Partials      142      141       -1
Impacted Files Coverage Δ
pkg/adaptor/xds/v3/route.go 73.61% <100.00%> (+0.16%) :arrow_up:
pkg/provisioner/xds/v3/grpc/types.go 71.10% <0.00%> (+2.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4b9c2bb...3ed4cfd. Read the comment docs.