search

apiaryio / api-blueprint

API Blueprint
https://apiblueprint.org
MIT License
8.64k stars 2.14k forks source link

Change API Blueprint logo #301

Closed pksunkara closed 8 years ago

kylef commented 8 years ago

Could we also update the image reference from the README so it's relative instead of referencing the "master" branch so this can be previewed?

- ![logo](https://raw.github.com/apiaryio/api-blueprint/master/assets/logo_apiblueprint.png)
+ ![API Blueprint Logo](assets/logo_apiblueprint.png)
pksunkara commented 8 years ago

@kylef It won't work all the time. It will work only in github. We should encourage direct links instead of github relative links which only work in github. I think using raw.github.com is better.

kylef commented 8 years ago

It won't work all the time. It will work only in github

Can you elaborate on when it won't work? I can't think of any cases this wouldn't work. Unless you only had the README.md file and not the image.

We should encourage direct links instead of github relative links which only work in github.

The biggest problem with this is that it references master which means all historic versions of the README will not be correct since "master" is a moving target.

pksunkara commented 8 years ago

Updated.