API v4 Bug: Delete Body Unused

apiaryio / api-blueprint

API Blueprint

https://apiblueprint.org

MIT License

8.65k stars 2.14k forks source link

API v4 Bug: Delete Body Unused #462

Closed joshwolff1 closed 4 years ago

joshwolff1 commented 4 years ago

Hello,

It looks like the values are not set in the DELETE method but are set elsewhere.

See here: In the DELETE method code, the data parameter in the function call is never used (and thus the values variable is not either), whereas they are used in the PATCH method (and the other methods).

In the PATCH method code (and for other methods), the request is composed as expected.

Mnau-mnau commented 4 years ago

@joshwolff1 This issue was fixed for python and released in v4 0.30.1

joshwolff1 commented 4 years ago

Thank you for the prompt fix.

I hate to re-open this, but I just noticed that GET has the same issue. I didn't notice this before