apiaryio / drafter

API Blueprint Parser (C++)
https://apiblueprint.org/
MIT License
301 stars 54 forks source link

Fix compatbility with MSVC and GYP #745

Closed kylef closed 5 years ago

kylef commented 5 years ago

https://github.com/apiaryio/drafter/pull/726 broken compatbility with MSVC which caused master to be unreleasable for a month. This PR reverts the changes that caused the problem to unblock releasing master. There were two problems, the code base couldn't be compiled on MSVC 2019:

ext\snowcrash\src\Just.h(21, 26): error C2131:  expression did not evaluate to a constant
ext\snowcrash\src\Just.h(21, 1): error C2440:  'noexcept': cannot convert from 'T' to 'bool
...
ext\snowcrash\src\Just.h(21, 26): message :  No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called

Protagonist CI couldn't complete on MSVC 2015 and caused an access violation causing the tests to exit.

This does mean that the test-asan CircleCI step will fail (it is not required).

This reverts commit 11a8788e660d608342c73f3269cbad10bab8d533. This reverts commit 893921c50ccf289fb940ff27b8191e209b29656f.

I have made no code changes, only reverted the two linked commits.

Fixes https://github.com/apiaryio/drafter/issues/738 Closes https://github.com/apiaryio/drafter/pull/742