Implementation of URITemplate parsing based on pegtl

apiaryio / drafter

API Blueprint Parser (C++)

https://apiblueprint.org/

MIT License

301 stars 54 forks source link

Closed klokane closed 4 years ago

klokane commented 4 years ago

grammar is implemented as recoverable parsing. While identifi error, it will roll back to start od token, then consume invalid part up to begin of new one part of grammar
it is will invoke different semantic action for valid and invalid part, so we are able to report it
it report invalid character in invalid token
in curent version if cannot report location of error (altrought it knows offset in URITemplate). Reason is, we receive sourcemap for MarkdownNode instead of start of URI template.

klokane commented 4 years ago

In this commit no. pegtl is included from drafter, not in snowcrash.

UriTemplate is part of drafter and we inlude this headers in snowcrash.

I propose to resolve it in individual commit after discussion about solution

klokane commented 4 years ago

So, we can merge? Or is there something to resolve?

kylef commented 4 years ago

@klokane I think this can be merged and I don't think there is any further feedback.