Closed kylef closed 4 years ago
When building with CMake, the version is returned as "Non-oficial drafter gyp-based build", which is incorrect.
$ ./src/drafter --version Non-oficial drafter gyp-based build
It would look like the code here is incorrect, and designed so that it checks for the presence of a macro CMAKE_BUILD_TYPE, which I don't think is ever set and thus always returns GYP version.
CMAKE_BUILD_TYPE
https://github.com/apiaryio/drafter/blob/32f5f873b9cf38cad30b2d07fa41aa4d5a8f1d39/src/drafter.cc#L234
When building with CMake, the version is returned as "Non-oficial drafter gyp-based build", which is incorrect.
It would look like the code here is incorrect, and designed so that it checks for the presence of a macro
CMAKE_BUILD_TYPE, which I don't think is ever set and thus always returns GYP version.https://github.com/apiaryio/drafter/blob/32f5f873b9cf38cad30b2d07fa41aa4d5a8f1d39/src/drafter.cc#L234