search

apiaryio / fury-adapter-swagger

Swagger 2.0 parser adapter for Fury.js
MIT License
11 stars 12 forks source link

fix: Add warning when x-example is not of correct type #116

Closed pksunkara closed 7 years ago

pksunkara commented 7 years ago

If you look at the validation for defaultValue, we do not care about number and boolean validations. So, I haven't done it for sample value too. I have only fixed the array validation for now because there are other validations we want to do when we want to start on it. It's better as a separate task.

kylef commented 7 years ago

@pksunkara Can you add a CHANGELOG entry please.

pksunkara commented 7 years ago

That's what I wrote in the description. It's not just limited to sample value. We need to do the checks elsewhere too. Which is why it's better as a separate task.

pksunkara commented 7 years ago

Re: changelog, I wanted to leave it to Thomas as part of his release task. And then introduce him about making it part of PRs.