Correct the sourcemap paths in convertParameterToMember

apiaryio / fury-adapter-swagger

Swagger 2.0 parser adapter for Fury.js

MIT License

11 stars 12 forks source link

Correct the sourcemap paths in convertParameterToMember #87

Closed pksunkara closed 8 years ago

pksunkara commented 8 years ago

Updated.

pksunkara commented 8 years ago

A Swagger operation which doesn't have parameters where the path has some parameters

There is a test for this already in x-example feature.

pksunkara commented 8 years ago

Unfortunately, I can't test the code in this PR using swagger-zoo because default value for path is this.path everywhere the function is being used.

I found the bug because I wanted to send a different path when merging the parameters and it didn't work.

coveralls commented 8 years ago

Coverage decreased (-0.006%) to 95.955% when pulling 8d25b56a9f6058ec510ea22bf289c7e8bd13fed4 on pksunkara/params into 98074c547d6a578e07df8b22c9b206f715cda81a on master.

pksunkara commented 8 years ago

@kylef Added functional tests. This is now ready.

coveralls commented 8 years ago

Coverage decreased (-0.006%) to 95.955% when pulling 1058c8a00072d85ae5fe0d48c8706d84a62ce4d7 on pksunkara/params into 98074c547d6a578e07df8b22c9b206f715cda81a on master.

pksunkara commented 8 years ago

Never mind about the codacy thing. I was just testing something.

kylef commented 8 years ago

:+1: