search

apiaryio / gavel.js

Validator of HTTP messages (JavaScript implementation)
MIT License
97 stars 22 forks source link

Revamp Cucumber steps and upgrade Cucumber #219

Open honzajavorek opened 5 years ago

honzajavorek commented 5 years ago

Cucumber in this repo is very outdated, which affects also how the Cucumber steps are implemented. The upgrade needs to be done manually (see dependabot attempt here - https://github.com/apiaryio/gavel.js/pull/217) and with care. When done, the infrastructure should be radically simplified. See e.g. https://github.com/apiaryio/dredd-hooks-template/ for inspiration.

artem-zakharchenko commented 5 years ago

Do we have a TPLTA approval to update cucumber?

I can update the package as a part of #221, as the pull request rewrites most of theall step definitions anyway. I've also spent some time with the latest Cucumber and I'm familiar with the latest step definition syntax. It should be feasible in that pull request's scope.

Please let me know the approval status. Thanks.

honzajavorek commented 5 years ago

@artem-zakharchenko cherry-pick this efb16f2, I'll take care of the rest

$ git fetch origin  # should download all remote branches on the background
$ git cherry-pick efb16f2  # pick this commit (from any branch known to git) and append it to my current branch