search

apiaryio / gavel.js

Validator of HTTP messages (JavaScript implementation)
MIT License
97 stars 22 forks source link

Text validation of URI with a surrogate pair #238

Open artem-zakharchenko opened 5 years ago

artem-zakharchenko commented 5 years ago

Previous implementation of Gavel contained a dedicated unit test for ensuring URIs with surrogate pairs in them are validated correctly by TextDiff:

https://github.com/apiaryio/gavel.js/blob/96f409240293fda91d9d1d0237b280cf18cc7477/test/unit/validators/text-diff-test.js#L54-L70

Implementation:

https://github.com/apiaryio/gavel.js/blob/96f409240293fda91d9d1d0237b280cf18cc7477/lib/validators/text-diff.js#L27-L31

Originally introduced in https://github.com/apiaryio/gavel.js/commit/dac0eff73727234d69ac7c97caaffdffe34e02ea.

During the API redesign we have discovered that removing the surrogate pairs handling still gives a passing test suite, so I'm removing the tests and implementation until more details are known about the intended behavior.

honzajavorek commented 5 years ago

@tu1ly I know this is ancient history, but do you happen to remember the original context for this?