search

apiaryio / gavel.js

Validator of HTTP messages (JavaScript implementation)
MIT License
97 stars 22 forks source link

[security] chore(deps-dev): bump semantic-release from 15.14.0 to 17.2.3 #533

Closed dependabot-preview[bot] closed 3 years ago

dependabot-preview[bot] commented 3 years ago

Bumps semantic-release from 15.14.0 to 17.2.3.

Release notes

Sourced from semantic-release's releases.

v17.2.3

17.2.3 (2020-11-16)

Bug Fixes

  • mask secrets when characters get uri encoded (ca90b34)

v17.2.2

17.2.2 (2020-10-29)

Bug Fixes

  • don't parse port as part of the path in repository URLs (#1671) (77a75f0)
  • use valid git credentials when multiple are provided (#1669) (2bf3771)

v17.2.1

17.2.1 (2020-10-12)

Reverts

  • Revert "feat: throw an Error if package.json has duplicate "repository" key (#1656)" (3abcbaf), closes #1656 #1657

v17.2.0

17.2.0 (2020-10-11)

Features

  • throw an Error if package.json has duplicate "repository" key (#1656) (b8fb35c)

v17.1.2

17.1.2 (2020-09-17)

Bug Fixes

  • add logging for when ssh falls back to http (#1639) (b4c5d0a)

v17.1.1

17.1.1 (2020-06-25)

Bug Fixes

v17.1.0

Commits
  • c8d38b6 style: removed line breaks to align with xo rule (#1689)
  • ca90b34 fix: mask secrets when characters get uri encoded
  • 63fa143 docs(plugins): add listing for new plugin (#1686)
  • 2bf3771 fix: use valid git credentials when multiple are provided (#1669)
  • 77a75f0 fix: don't parse port as part of the path in repository URLs (#1671)
  • d74ffef docs: add npm-deprecate-old-versions in plugins list (#1667)
  • 3abcbaf Revert "feat: throw an Error if package.json has duplicate "repository" key (...
  • b8fb35c feat: throw an Error if package.json has duplicate "repository" key (#1656)
  • 18e35b2 docs: reorder default plugins list (#1650)
  • e35e5bb docs(contributing): fix commit message examples (#1648)
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in the `.dependabot/config.yml` file in this repo: - Update frequency - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired)
dependabot-preview[bot] commented 3 years ago

We've just been alerted that this update fixes a security vulnerability:

Sourced from The GitHub Security Advisory Database.

Secret disclosure when containing characters that become URI encoded

Impact

Secrets that would normally be masked by semantic-release can be accidentally disclosed if they contain characters that become encoded when included in a URL.

Patches

Fixed in v17.2.3

Workarounds

... (truncated)

Affected versions: ["<= 17.2.2"]

artem-zakharchenko commented 3 years ago

Since we've migrated from CircleCI, ci:release isn't executed during the CI anymore.

I suggest we still update semantic-release so we could use it with GitHub actions in the future.

artem-zakharchenko commented 3 years ago

semantic-release@17.0.0 requires node >= 10.18 as a breaking change. I'm bumping the node version used for development in .nvmrc to 12.18.0 to stay closer to the LTS version. Verified locally, the tests and the build are passing with node@12.18.0.

kuba-kubula commented 3 years ago

@artem-zakharchenko excuse me, but: 10.18+ is not the same as 12.18... (see 10 vs 12). Wouldn't 12.x be good enough?

artem-zakharchenko commented 3 years ago

@kuba-kubula, you're right. I've discussed this with @abtris and he recommended to skip v10 bump because its support ends this April.

The notion to bump the Node version is for Gavel to operate on the supported Node version, which, taking the sentence above into account, would be node 12. I don't mind choosing either of these options, let's just agree whether we move to 12, or stick with 10.

kuba-kubula commented 3 years ago

@artem-zakharchenko I think I'd love to keep Node >=10.18 in package.json as minimal version. But feel free to use node 12 for semver release.

artem-zakharchenko commented 3 years ago

Makes sense to me. Thanks, @kuba-kubula. 10.18 is set as the next required Node version to use Gavel.

kuba-kubula commented 3 years ago

@artem-zakharchenko maybe we should tweak travis config to not use node 8 anymore also.

artem-zakharchenko commented 3 years ago

@kuba-kubula a great point. Will change its config in a follow-up pull request.

artem-zakharchenko commented 3 years ago

Created a follow-up to adjust TravisCI configuration: https://github.com/apiaryio/gavel.js/pull/552

ApiaryBot commented 3 years ago

:tada: This PR is included in version 10.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: