apiaryio / gavel2html

Renders HTML diff from Gavel.js output
MIT License
0 stars 0 forks source link

Architecture #16

Open honzajavorek opened 5 years ago

honzajavorek commented 5 years ago

This library should get rewritten from scratch.



Update: The gavel2html branch for 0.2.0-unstable.1, which is used by apiary.io, has been recovered from @kuba-kubula's backup disk. It is now pushed to GitHub under kubula/customize_json_converter_html branch name.

artem-zakharchenko commented 5 years ago

Can somebody verify which of the next branches are actually up-to-date with what is used in the core app?

  1. kubula/customize_json_converter_html
  2. kubula/customize_headers_converter

Commits diff states it's the first one, but I would like somebody to verify that.

kuba-kubula commented 5 years ago

@artem-zakharchenko @honzajavorek

From what I see in branches and history of git:

  1. there's tag v0.1.0 at commit 1f0d32c
  2. there's a branch based on that ^^^ tag, named kubula/customize_headers_converter (with 5 commits, last is 906cde7)
  3. there's a branch based on that ^^^ branch's last commit, named kubula/customize_json_converter_html (with 7 additional commits, last is dd4d441 with commit message bump to 0.2.0-unstable – although the change to version in the package.json file was a 0.2.0-unstable.1 version)

I can verify that there's that version published to npm registry, using command:

$ npm view gavel2html@0.2.0-unstable.1 gitHead
dd4d441efa04d948ba2009a83f70910ba3871c51

That ^^^ is the same hash as the last commit in branch kubula/customize_json_converter_html

─ v0.1.0
└ kubula/customize_headers_converter
  └ kubula/customize_json_converter_html
artem-zakharchenko commented 5 years ago

17 ensures current master equals to the @kuba-kubula's feature branch currently used in the core app. #18 published that master to npm.

artem-zakharchenko commented 5 years ago

Published the actually used package version to NPM. Version: 1.0.2.