fix: fallbacks to an empty object during "getFromString"

apiaryio / gavel2html

Renders HTML diff from Gavel.js output

MIT License

0 stars 0 forks source link

fix: fallbacks to an empty object during "getFromString" #21

Open artem-zakharchenko opened 5 years ago

artem-zakharchenko commented 5 years ago

Fixes an issue in the Core app when headers.values.expected is not defined sometimes.

honzajavorek commented 5 years ago

We were able to identify the root cause and I think we should compensate for it in the apiary.io core app. Although we could say that this PR supports the robustness principle, I think in this case gavel2html shouldn't be benevolent and should throw on unexpected input structure. This actually helps to catch mistakes early.

artem-zakharchenko commented 5 years ago

I would love not to introduce this handling, as it's too much for gavel2html. Would need to investigate the core problem.