apibara / starknet-react

A collection of React providers and hooks for StarkNet
https://starknet-react.com
MIT License
369 stars 147 forks source link

update starknet dependency version to 5.9.1 #253

Closed rjnrohit closed 1 year ago

fracek commented 1 year ago

I agree with this. From our discussion on telegram my understanding is the following:

My idea is that for the time being we should wrap the account v4 into a shim that implements the account v5 interface (and throws if the library/dev tries to use a new method).

What do you think?

fracek commented 1 year ago

I looked more into this tonight.

At the moment and for the next few weeks, all injected wallets will still implement the account interface from v4. So the only way I see adding support for v5 is by:

  1. explicitly request a v4 account interface to the wallet
  2. wrap the v4 account into a shim that implements the v5 interface
  3. use the shim as the starknet-react provider

in a few weeks/months once v4 is officially deprecated, we can start requesting v5 and discard the shim.

What do you think?

fracek commented 1 year ago

v5 is now supported.