Closed rjnrohit closed 1 year ago
I looked more into this tonight.
library.chainId
becoming await library.getChainId()
. We can wrap this into a hook so the change is simple.get-starknet-core
has starknet
as a peer dependency. This is what seems to be causing issues.At the moment and for the next few weeks, all injected wallets will still implement the account interface from v4. So the only way I see adding support for v5 is by:
in a few weeks/months once v4 is officially deprecated, we can start requesting v5 and discard the shim.
What do you think?
v5 is now supported.
I agree with this. From our discussion on telegram my understanding is the following:
get-starknet
and wallets return an object that implements theAccountInterface
v4AccountInterface
v5My idea is that for the time being we should wrap the account v4 into a shim that implements the account v5 interface (and throws if the library/dev tries to use a new method).
What do you think?