search

apibara / starknet-react

A collection of React providers and hooks for StarkNet
https://starknet-react.com
MIT License
369 stars 147 forks source link

feat: screen done #380

Closed okhaimie-dev closed 10 months ago

okhaimie-dev commented 11 months ago

Changes

netlify[bot] commented 11 months ago

Deploy Preview for starknet-react ready!

Name Link
Latest commit c90c723c9616f05c4f7f3d2f0eae279804f0b82e
Latest deploy log https://app.netlify.com/sites/starknet-react/deploys/659870807444f40008c9500d
Deploy Preview https://deploy-preview-380--starknet-react.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

fracek commented 11 months ago

Sorry for taking so long to review. I run the demo:

okhaimie-dev commented 11 months ago

Sorry for taking so long to review. I run the demo:

  • can you use tamagui for the button and views? That way it's easy to set a consistent design.
  • using ToastAndroid seems to break the web build. The web build is the most important one for now.
  • Can you generate the private/public key in setup.tsx? We can use jotai to persist the key across sessions

Alright, I will take note of this and revert. Will make a PR in a bit

okhaimie-dev commented 10 months ago

Can you generate the private/public key in setup.tsx? We can use jotai to persist the key across sessions

The web build fails when I try to use starknet as a dependency. Here is a branch where I am working to implement the account generation feature with jotai https://github.com/okhaimie-dev/starknet-react/tree/jotai And I am still trying to wrap my head around how to effectively get the account generation feature work in general.

Aside, I fixed the other issues.

fracek commented 10 months ago

Looks good! Thank you