Contract deploy does not works with braavos injected wallet.

apibara / starknet-react

A collection of React providers and hooks for StarkNet

https://starknet-react.com

MIT License

362 stars 142 forks source link

Contract deploy does not works with braavos injected wallet. #440

Closed prix0007 closed 3 months ago

prix0007 commented 4 months ago

Steps to Reproduce:

Create a scaffold create react app
- npx create-starknet-app@latest app_name debugger
Connect Braavos with running sacffold application
Navigate to scaffold deployer page: http://localhost:3000/scaffold-deployer
Try deploying contract with Already declared class hash (i.e on sepolia:0x045b176b50d6430f58655c25020d2012ce9d198f972f7e0e0e5296c8d7b3151a)

Expected: Wallet pop up for deploying contract on braavos

Result: No action happens, keeping clicking deploy doesn't do anything.

Notes: Works fine with ArgentX Injected wallet connect.

prix0007 commented 4 months ago

Attaching SS from dependencies in scaffold at the time of creating issue

Iwueseiter commented 4 months ago

@prix0007 Please can I work on this?

prix0007 commented 4 months ago

Please do that @Iwueseiter . Looking forward to your solution.

Iwueseiter commented 4 months ago

Alright

fracek commented 4 months ago

Does it print any error in the console? Does it work with argent?

prix0007 commented 4 months ago

Nope no error on logs, just the function call get's stuck. Works fine with argent wallet.

prix0007 commented 3 months ago

Update: There was an issue with Braavos Wallet and they have fixed it into prod. Maybe we can have a timeout in lib itself, else we can close the issue.

cc. @fracek

avimak commented 3 months ago

Greetings from Braavos team 👋 Please try with Braavos v3.50.0 (and above) 🙏

fracek commented 3 months ago

Will close the issue for now! Thank you for reporting.