search

apibara / starknet-react

A collection of React providers and hooks for StarkNet
https://starknet-react.com
MIT License
362 stars 142 forks source link

Issue when both ArgentX and Braavos wallets enabled #97

Closed Pet3ris closed 2 years ago

Pet3ris commented 2 years ago

Running into this issue on Brave where if both ArgentX and Braavos wallets are enabled, I get the following error:

Screen Shot 2022-05-03 at 3 12 24 PM

fracek commented 2 years ago

Related to #77. Need to fix this ASAP.

fracek commented 2 years ago

It looks like the error originates from the Braavos extension? The chrome extension id is the one from the Braavos extension. /cc @avimak

avimak commented 2 years ago

@fracek the root cause actually sits in argent's extension, see here

fracek commented 2 years ago

Where should we track this issue? /cc @janek26

Pet3ris commented 2 years ago

This is a good tweet from Vitalik of the benefit of testing with multiple wallets: https://twitter.com/VitalikButerin/status/1531771109602799617.

fracek commented 2 years ago

109 fixes this. Let's get it merged.

fracek commented 2 years ago

This is now fixed.