search

apideck-libraries / vault-core

Apideck Vault Modal component for React
https://www.apideck.com/products/vault
MIT License
7 stars 1 forks source link

Vault: Add prop to remove logo on top of modal #69

Closed jakeprins closed 1 year ago

jakeprins commented 1 year ago

Optionally add logo URL to show on top of the modal.

If none is provided, it shouldn't show a logo and UI should be adjusted.

Linked to the Xero App approval process for the partner.

Gdewilde commented 1 year ago

@jakeprins Thanks for fixing this. Is this listed in the README?

jakeprins commented 1 year ago

fyi Instead of a prop, it uses the theme object which could have the logo property. I've updated the readme's to include that.

Gdewilde commented 1 year ago

Wouldnt' the icon be a better match since it's most of the time a square? Do you have a preview?

jakeprins commented 1 year ago

It's a setting you need to set through the session, so it depends on what image URL is provided. If nothing is provided it doesn't show anything and otherwise, the image that you have provided is to be shown there. Like on the website, we provide a logo, so it looks like it always did: CleanShot 2023-01-20 at 15 21 28

Only the Platform API doesn't apply the theme object yet when provided during the creation of the session, which I created an issue for https://github.com/apideck-io/platform-api/issues/276

Gdewilde commented 1 year ago

Ok, thanks for the explainer. Great work.