search

apify / actor-templates

This project is the :house: home of Apify actor template projects to help users quickly get started.
https://apify.com/
25 stars 14 forks source link

chore: fix ci for new playwright #204

Closed vladfrangu closed 12 months ago

B4nan commented 12 months ago

sidenote: where is that 0.5 estimate coming from? was it there or did you add it? i dont think we need that, 1 means its a simple task that took up to one hour, this does not need to be precise, we dont need to care about "this was even simpler than 1 hour". usually even the super simple things end up as ~1 hour due to the reviews and whatnot

vladfrangu commented 12 months ago

Yeah that was added by me, since I've never really dealt with estimates before 😅😅, good to know

B4nan commented 12 months ago

so the problem was version mismatch between what is used in the tests and what is used in the template itself?

vladfrangu commented 12 months ago

Yep, that was all. Base repo installed <1.38.0 (not sure exactly which version), which also installed an older chrome, whereas the templates installed * -> whatever @latest is -> expecting newer chrome

B4nan commented 12 months ago

In that case I'd say we should have * in the root dependencies too.

vladfrangu commented 12 months ago

Not fully sure if that'll matter since the root has a lockfile.. we can try it and see what happens?

B4nan commented 12 months ago

Hmm, maybe we should add renovate to this repo too, at least for the lockfile updates.

For now, let's just merge so the tests are passing again.

B4nan commented 12 months ago

looks like it did not help at all, how come the PR checks were passing?

vladfrangu commented 12 months ago

Well it failed for a completely different reason, seems to be related to langchain