apify / apify-actor-docker

Base Docker images for Apify actors.
https://hub.docker.com/u/apify
Apache License 2.0
70 stars 22 forks source link

feat: node 18 support, crawlee and bullseye #83

Closed vladfrangu closed 2 years ago

vladfrangu commented 2 years ago
vladfrangu commented 2 years ago

Right off the bat I can see that nodejs 14 and 15 are probably to be removed if we want to move to actor sdk + crawlee... Is that ok? Are we ready for that?

szmarczak commented 2 years ago

Right off the bat I can see that nodejs 14 and 15 are probably to be removed if we want to move to actor sdk + crawlee... Is that ok? Are we ready for that?

I'd wait once people start using Node.js 18 more (a few weeks). Then there will be a drop-off in Node.js 14 users. No strong opinions however, we can remove it as well.

B4nan commented 2 years ago

I would drop node < 16 right ahead. Why should we base this on usage of node 18? Also, the old images will be still there for people using v2. Using v3 requires node 16.

pocesar commented 2 years ago

this will also instantly fix this: https://github.com/nodejs/node/issues/39400 and https://github.com/nodejs/node/issues/32978

B4nan commented 2 years ago

this will also instantly fix this: https://github.com/nodejs/node/issues/39400 and https://github.com/nodejs/node/issues/32978

fyi node 18 images will be opt in before lts is out, we will keep node 16 in the templates

pocesar commented 2 years ago

the hardcoded NODE_VERSION=16 will make it possible to use :18 on Dockerfile? or is there a separate image that will be created?

vladfrangu commented 2 years ago

the hardcoded NODE_VERSION=16 will make it possible to use :18 on Dockerfile? or is there a separate image that will be created?

Yep! That's just the default value if not specified! If we specify NODE_VERSION=18 in CI we'll build a node 18 image