feat: Python course lesson about saving data

apify / apify-docs

This project is the home of Apify's documentation.

https://docs.apify.com

Apache License 2.0

29 stars 76 forks source link

feat: Python course lesson about saving data #1205

Closed honzajavorek closed 1 month ago

honzajavorek commented 2 months ago

TODO

[x] intro etc.
[x] export to CSV
[x] export to JSON
[x] fix CI errors
[x] exercises
[x] polish the texts
[x] lesson closing

honzajavorek commented 2 months ago

What do you mean by Crawlee extension? Similar to the JS course, I want to tackle crawling now and then show how this all can be simplified using Crawlee. Not sure yet at which point I'll introduce Crawlee exactly, in the JS course it takes 5 more lessons before Crawlee is mentioned. I'd like to keep the code simple enough so it's easy to follow and once it isn't, I'd bring Crawlee in.

honzajavorek commented 2 months ago

More TODO:

[x] fix filename= in code examples, should be title=
[x] fix order of imports, keep them in subsequent order as they're added throughout the course (now Decimal is suddenly first... could be alphabetically, but imho that just adds unnecessary cognitive load)
[x] rebase?

mnmkng commented 1 month ago

@honzajavorek is this mergeable? The "TODO" in the original post scared me a bit. All the TODOs are checked, but still not sure if we can merge. Thanks!

honzajavorek commented 1 month ago

@mnmkng yup, it is! I would keep it as a draft otherwise.

honzajavorek commented 1 month ago

Regarding reviews, is it okay to merge now? I assign all four of you, taking Ondra and Lukas as optional. But now I have Vlada approving and Ondra approving, so...

Would it make sense if I always wait for @vdusek (or other pythonistas willing to step in) to check Python, and then perhaps approval from any of you three (Ondra / Lukas / Michał) would then mean it's good to go?

mnmkng commented 1 month ago

Certainly good to merge 👍🏻 but I agree that waiting for @vdusek to check the Python makes sense 😅