apify / apify-docs

This project is the home of Apify's documentation.
https://docs.apify.com
Apache License 2.0
29 stars 76 forks source link

Checking absolute links expects URLs that are after redirect #1220

Open metalwarrior665 opened 1 month ago

metalwarrior665 commented 1 month ago

See for example this action check https://github.com/apify/apify-docs/actions/runs/10892978578/job/30226981711?pr=1217

It cannot resolve academy/tutorials/node-js/scraping-from-sitemaps.md which is how it exists in the filesystem. The article URL is https://docs.apify.com/academy/node-js/scraping-from-sitemaps

Do I need to bite the bullet and rename the link like that or could we resolve this so all links can work like in the filesystem? @honzajavorek @TC-MO

B4nan commented 1 month ago

It cannot resolve academy/tutorials/node-js/scraping-from-sitemaps.md which is how it exists in the filesystem

nope, the path uses _ instead of -:

https://github.com/apify/apify-docs/blob/master/sources/academy/tutorials/node_js/scraping_from_sitemaps.md

you either use a file path or the URL