apify / apify-docs

This project is the home of Apify's documentation.
https://docs.apify.com
Apache License 2.0
28 stars 73 forks source link

Visual nitpics #805

Closed valekjo closed 8 months ago

valekjo commented 9 months ago
image.png image.png

Reported on slack: https://apifier.slack.com/archives/C0L33UM7Z/p1703684285889429

jbartadev commented 9 months ago

@webrdaniel Seems like the issue is that it worked locally but not on prod and tooling team seems to be already dealing with it here https://github.com/apify/apify-docs/pull/807

m-murasovs commented 9 months ago

cc @webrdaniel Reported by Pavel: This also causes some issues for google indexing, so it would be good to keep an eye on this

Screenshot 2024-01-10 at 13 45 20
B4nan commented 9 months ago

Hmm, maybe we should try to replace those badges with empty <span> that has the text added via CSS?

webrdaniel commented 9 months ago

line-height fixed by https://github.com/apify/apify-docs/pull/807 For the Crawlee issue created an issue here: https://github.com/apify/crawlee/issues/2282

B4nan commented 9 months ago

For the Crawlee issue

The same problem is present here as well, or better say, in the project docs, e.g. in SDK or client, where we also have API reference. Hopefully this can be fixed from inside the shared docusaurus theme which is defined in this repository.

So I guess let's keep this one open so we don't forget to fix it here too. (and changing the labels as this part is on our shoulders)

webrdaniel commented 9 months ago

For the Crawlee issue

The same problem is present here as well, or better say, in the project docs, e.g. in SDK or client, where we also have API reference. Hopefully this can be fixed from inside the shared docusaurus theme which is defined in this repository.

So I guess let's keep this one open so we don't forget to fix it here too. (and changing the labels as this part is on our shoulders)

@B4nan Ok, thanks 👍