search

apify / apify-shared-js

Utilities and constants shared across Apify projects.
https://www.npmjs.com/package/@apify/utilities
Apache License 2.0
12 stars 11 forks source link

feat: Remove @apify/consts private package dependency #449

Closed jancurn closed 8 months ago

jancurn commented 8 months ago

@apify/consts is a private package, and thus the @apify/log package couldn't be used in public packages. This fixes it. See also https://apifier.slack.com/archives/C01VBUV81UZ/p1708427261484589

B4nan commented 8 months ago

all packages in this repository are public, sounds like you are confusing the private packages used in apify-core published to GH registry, everything you see here is published directly to NPM

jancurn commented 8 months ago

@B4nan dam it, you're right, I should probably do some other job 🙈

B4nan commented 8 months ago

with that said, i never understood why we have two sets of the packages, i ges that some needs to be private, but why are we duplicating stuff like the logger or the consts? i would say we should have only the extra private packages there and otherwise use the public ones (and for private consts we should have something like "private-consts" package)

jancurn commented 8 months ago

🤷‍♂️

jirimoravcik commented 8 months ago

with that said, i never understood why we have two sets of the packages, i ges that some needs to be private, but why are we duplicating stuff like the logger or the consts? i would say we should have only the extra private packages there and otherwise use the public ones (and for private consts we should have something like "private-consts" package)

well some constants are indeed, private. and it's easier to change the private package because they're in a monorepo with other apps, so I guess that's why some things that should have ended up here are in private consts...