search

apify / apify-storage-local-js

Local emulation of the apify-client NPM package, which enables local use of Apify SDK.
3 stars 4 forks source link

feat: TypeScript conversion base #15

Closed vladfrangu closed 3 years ago

vladfrangu commented 3 years ago

This PR sets the base for converting to TypeScript. As it stands, it allows the current project to be built as is, while also generating some form of typings (thanks tsc).

I've also made jest TS ready, and added mjs support! After this PR is merged, I can start converting files :3

B4nan commented 3 years ago

i am voting to keep it ¯_(ツ)_/¯

vladfrangu commented 3 years ago

gen-esm-wrapper can go

While I understand, gen-esm-wrapper is the simplest way to automatically add native support for ESM/MJS, which I know more and more people are using. If the consensus is to remove it, then I will, just let me know 😄

mnmkng commented 3 years ago

Cool. Thanks @vladfrangu