search

apify / apify-ts

Crawlee dev repo
https://crawlee.dev
Apache License 2.0
22 stars 3 forks source link

docs: more updates to api docs - browser-crawler package #180

Closed AndreyBykov closed 2 years ago

AndreyBykov commented 2 years ago

There's only few tiny changes to basic crawler + browser crawler package should be done. I'm slow as hell today - probably should not go to sleep at 7 am 😄. I would rather push more changes (not to create 10 PRs for this). But it COULD be merged already, this browser-crawler package is done from my perspective.

One thing I wanted to ask - is it intentional that browser-pool is not exposed? I have replaced the BrowserPool links to the current apify-ts repo, but it would change. So I should either update the links later, or if BrowserPool will be shown in the api docs - I would replace it with {@link BrowserPool}.

One more thing not to forget - search on the site still does not work - is it expected?

B4nan commented 2 years ago

Search does not work because algolia guys are slow as hell. I'm in contact with them.

B4nan commented 2 years ago

Good catch about the browser pool, added now to API docs.

AndreyBykov commented 2 years ago

updated the links, the example tag, updated Actor links in apify-guide. Wanna merge it or I could continue here? @B4nan

B4nan commented 2 years ago

do another PR, i want to have the docs as up to date as possible as they are live already