search

apify / browser-pool

A Node.js library to easily manage and rotate a pool of web browsers, using any of the popular browser automation libraries like Puppeteer, Playwright, or SecretAgent.
87 stars 14 forks source link

fix: proxyUrl in incognito context #51

Closed szmarczak closed 2 years ago

szmarczak commented 2 years ago

Fixes https://github.com/apify/apify-js/issues/1195 a breaking change introduced by https://github.com/puppeteer/puppeteer/pull/7516

szmarczak commented 2 years ago

/cc @corford

B4nan commented 2 years ago

please update the changelog before merging

(we really need to get this automated soon, it gets so tedious :])

corford commented 2 years ago

@szmarczak friendly prod (...unless we temporarily fork the repo we're blocked on this hotfix until it gets merged)

B4nan commented 2 years ago

We will merge this later today or tomorrow, and ship sdk 2.1 probably on wednesday or thursday with the updated version too.

corford commented 2 years ago

Ok, awesome - thanks!

B4nan commented 2 years ago

browser pool 2.0.4 stable is out with the fix (will get published in few minutes)