search

apify / browser-pool

A Node.js library to easily manage and rotate a pool of web browsers, using any of the popular browser automation libraries like Puppeteer, Playwright, or SecretAgent.
87 stars 14 forks source link

fix: skip proxy-chain #53

Closed szmarczak closed 2 years ago

szmarczak commented 2 years ago

Fully removes the need for proxy-chain in browser-pool. Some incorrect tests were fixed as well.

szmarczak commented 2 years ago

No idea why but

  ● Plugins › Playwright specifics › with chromium › should work with non authenticated proxyUrl
  ● Plugins › Playwright specifics › with chromium › should work with authenticated proxyUrl

are failing, looks like the request doesn't go through the proxy server at all 🤔 It's working for other playwright browsers.

Basically 127.0.0.1 is used for the target server, 127.0.0.2 for the unprotected proxy, 127.0.0.3 for the protected proxy. The request should come from 127.0.0.2 / 127.0.0.3 but comes directly from 127.0.0.1.

B4nan commented 2 years ago

dont forget to update the changelog and describe why we think this change might be breaking

szmarczak commented 2 years ago

GitHub Actions stopped working again :|

szmarczak commented 2 years ago

Windows is currently blocked by https://github.com/puppeteer/puppeteer/issues/7698 should we merge (will update changelog if we decide to do so)?

mnmkng commented 2 years ago

Yeah, let's merge. It's a new feature so windows users will have to wait a bit, but Linux is far more important.