search

apify / browser-pool

A Node.js library to easily manage and rotate a pool of web browsers, using any of the popular browser automation libraries like Puppeteer, Playwright, or SecretAgent.
87 stars 14 forks source link

fix: support puppeteer v14.4+ #79

Open B4nan opened 2 years ago

B4nan commented 2 years ago

Closes #78

corford commented 2 years ago

@B4nan Do you have a rough ETA when this will get merged & released?

B4nan commented 2 years ago

Its weird that the CI fails so hard, especially ubuntu tests that are usually less flaky than windows ones.

The priority is now crawlee release, which should happen on wednesday, so I hope there will be some time for this one afterwards (it is already addressed in @crawlee/browser-pool@next).

corford commented 2 years ago

@B4nan Gentle ping to ask if this is still planned to be merged?

B4nan commented 2 years ago

Have you tried @crawlee/browser-pool? We could ship one last version, but given the failing tests I would rather not.

I could definitely offer merging this, which will ship a new beta version, I am just a bit affraid of releasing new stable.

corford commented 2 years ago

Have you tried @crawlee/browser-pool?

Yep, we're currently targetting @crawlee/browser-pool (and puppeteer v15) via an apify overrides block in packages.json. Seeing some instability with page crashes on certain sites. It might not be related though - haven't had time to debug yet.

Understand your reluctance to role a new stable. A beta would be super helpful though 👍 (we'll start our migration effort over to Crawlee soon anyway, so this is only a temporary bandaid).

B4nan commented 2 years ago

Ok will try to get back to this during the week and merge at least parts of it. We merged puppeteer 17.0 support to crawlee just yesterday, so it would be good to bump it here too.

(we are holding from 17.1 as it might not be compatible with latest stable chrome)