Switch to TypeScript - Githubissues

apify / got-scraping

HTTP client made for scraping based on got.

526 stars 40 forks source link

Switch to TypeScript #31

Closed szmarczak closed 3 years ago

szmarczak commented 3 years ago

TODO after this gets merged:

https://github.com/apify/apify-js/issues/1008
fix leaking alpn negotiation

Closes #21

mnmkng commented 3 years ago

cc @vladfrangu

szmarczak commented 3 years ago

this are still a lot of those FIXME type comments, do you plan to resolve all of them before merging the PR? if not, we should be probably more specific instead of just saying FIXME, at least in the actual code base (it's fine'ish in tests)

Fixed the two in index.ts and http2.ts.

The ones in main.test.ts are unfixable atm, see https://github.com/sindresorhus/got/issues/1117 - I'll try to fix them later.

The PR is good to merge if there is no more questions.

szmarczak commented 3 years ago

@B4nan Friendly ping :)