search

apify / got-scraping

HTTP client made for scraping based on got.
422 stars 32 forks source link

fix: allow passing extra options like `proxyUrl` on type level #88

Closed vladfrangu closed 1 year ago

vladfrangu commented 1 year ago

This solves an internally reported issue where using got-scraping would not include our custom options (like proxyUrl)

Closes #66

B4nan commented 1 year ago

Also, there are tests that should no longer need the type assertions to OptionsInit.

vladfrangu commented 1 year ago

Looking good I guess, let's test this via crawlee test suite (jest + e2e) to be sure (once merged, but before stable release).

Hard to do without this merged / released 😓, or? should I try it out with patch-package?

B4nan commented 1 year ago

After this gets merged of course, on the got scraping beta.