SOCKS Authentication fails for CONNECT if username contains special characters

[mschfh]

SOCKS authentication fails for CONNECT requests when the username contains a @:

proxyChain.anonymizeProxy({url: "socks5://foo@bar.baz:hunter2@example.com:1080", port: 12345})

For a HTTP request, everything works as expected (the username is sent as-is).

curl -v --proxy 'http://127.0.0.1:12345' 'http://ifconfig.co'

For a HTTPS / CONNECT request, the username sent to the upstream SOCKS5 proxy is URL escaped (e.g. foo%40bar.baz, as seen in a packet capture) and the SOCKS authentication request fails due to incorrect credentials, the proxy returns a 597 error.

curl -v --proxy 'http://127.0.0.1:12345' 'https://ifconfig.co'

[jirimoravcik]

Fixed in #550

[mschfh]

Thank you, the fix works as expected.