search

apigee-127 / bagpipes

Less code, more flow. Let's dance!
MIT License
47 stars 30 forks source link

Does not work with Jest #31

Open muhmud opened 6 years ago

muhmud commented 6 years ago

Hi,

There's a bug fix for release 0.1.0 in bagpipes/lib/fittingTypes/user.js when using bagpipes with Jest, however, this hasn't been released?

Would that be possible?

Thanks,

WaldoJeffers commented 6 years ago

Yes @theganyo please; this is absolutely critical for my team. It's basically impossible to require the file where swagger-node is instanciated (usually app.js), making it impossible to test with Jest or other test frameworks.

theganyo commented 6 years ago

Done! 0.1.1 has been released. Hope this works for you!

WaldoJeffers commented 6 years ago

@theganyo works like a charm, thank you!

muhmud commented 6 years ago

Works for me too, thanks!

theganyo commented 6 years ago

@WaldoJeffers @muhmud The patch submitted for this had to be rolled back in 0.1.2 because of regressions. Are you saying that it still works fine or that you're pinning on version 0.1.1?

WaldoJeffers commented 6 years ago

@theganyo Haven't tried version 0.1.2. To fix my issue, I had to lock my version to 0.1.1 (which was 0.1.0 at the time). Does that help @theganyo ?

theganyo commented 6 years ago

I was just curious and wanted to give you the heads up as I assume it will no longer work. A better considered and tested PR will be needed before this goes in again.

WaldoJeffers commented 6 years ago

Okay, thanks. The version is locked down in my yarn.lock file, but thanks for the heads up. Appreciated. Should we re-open this issue or not?

theganyo commented 6 years ago

Sure. But the issue title is incorrect. I'll reopen and change it.