Memory leak

[tbflw]

After spending a lot of time investigating, debugging and heap dumping a problem across all our swagger-node production services we have localised a memory leak in swagger-node-runer 0.7.3. The leak is most likely caused by a downstream dependency (z-schema) which was released in version 3.18.3 on August 19th. This release contains a new implementation of a ReferenceCache which we suspect is the cause of the leak (https://github.com/zaggino/z-schema/commit/b1ea164b7acba124de45d149b42279411e6eefeb).

Here's a screenshot showing the memory usage of one of our services with the memory leak and without.

The screenshot without the memory leak is from the service built with the following shrinkwrap configuration to lock down the dependency on z-schema to version 3.18.2:

{
  "dependencies": {
    "swagger-express-mw": {
      "version": "0.7.0",
      "from": "swagger-express-mw@0.7.0",
      "dependencies": {
        "swagger-node-runner": {
          "version": "0.7.3",
          "from": "swagger-node-runner@0.7.3",
          "dependencies": {
            "sway": {
              "version": "1.0.0",
              "from": "sway@1.0.0",
              "dependencies": {
                "z-schema": {
                  "version": "3.18.2",
                  "from": "z-schema@3.18.2"
                }
              }
            }
          }
        }
      }
    }
  }
}

[theganyo]

Thank you for tracking this down! Since this is a Sway dependency issue, do you mind opening an issue there and linking back to this?

[theganyo]

Actually, it should really be addressed by z-schema. It would be best to go to the source and get it fixed instead of attempting to lock it down to a prior version.

[tbflw]

Since this bug is handled upstream, I think it's OK to close it.