search

apigee-127 / swagger-node-runner

The heart of Swagger-Node
MIT License
102 stars 123 forks source link

Allow mocks for paths without a controllerName #119

Closed penx closed 6 years ago

penx commented 6 years ago

Fixes #118

This means, for example, that if you set defaultPipe: swagger_controllers and controllerName is undefined, then it skips looking for a controller (as path.resolve(controllersDirs[i], controllerName) would error) and continues to making a mock.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 95.625% when pulling 3d9f3d140df2a17807a3a2eb04e40a2ffa48ea89 on penx:feature/always-mock-paths into 7f85797e74ee8a182ae9458ac8e2eb4db9c7a6c3 on theganyo:master.

penx commented 6 years ago

@theganyo I'm hoping to use swagger-node-runner in a mock tool which is dependent on this fix and #121. Any chance on some feedback on these ? Or should I publish a fork with my fixes?

https://github.com/penx/openapi-mock https://github.com/penx/openapi-mock/issues/5

Thanks!

theganyo commented 6 years ago

No, These seem good. I've merged them. Thanks.